Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing import causing runtime_error to not be found. #111

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Added missing import causing runtime_error to not be found. #111

merged 1 commit into from
Nov 5, 2020

Conversation

Nexushunter
Copy link
Contributor

@Nexushunter Nexushunter commented Nov 5, 2020 •
edited
Loading

Problem

Upon initial setup, there was an issue with runtime_error not being picked up. It turns out an import <stdexcept>was missing.

Solution

Add missing import.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 348425826

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.921%
Totals Coverage Status
Change from base Build 340473780: 0.0%
Covered Lines: 15488
Relevant Lines: 18906
💛 - Coveralls

@water111
Copy link
Collaborator

water111 commented Nov 5, 2020

Good catch, thanks!

If you are interested, we have a discord here for discussing development here: https://discord.gg/z4ChyVPJcx

@water111 water111 merged commit f5ed2e6 into open-goal:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nexushunter @coveralls @water111