Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GOAL stack to GOAL memory #114

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Nov 7, 2020

Previously GOAL code ran in the stack from the EE thread. This makes the GOAL stack be located outside of the GOAL address space, which has all sorts of problems. GOAL threading won't work, and you can't get GOAL addresses of things on the stack. It's also an issue for the debugger which is set up to read memory in the GOAL address space.

Breaking into a separate PR because I think this will take a bunch of work to get on windows.

@coveralls
Copy link

coveralls commented Nov 7, 2020

Pull Request Test Coverage Report for Build 350579114

  • 16 of 17 (94.12%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 81.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
game/overlord/iso_cd.cpp 0 1 0.0%
Totals Coverage Status
Change from base Build 350044265: 0.009%
Covered Lines: 15806
Relevant Lines: 19415

💛 - Coveralls

@water111 water111 merged commit 71a894c into master Nov 7, 2020
@water111 water111 deleted the w/put-goal-stack-on-goal-heap branch November 7, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants