Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Arch installation steps, and some typos #1165

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Feb 13, 2022

No description provided.

README.md Outdated
@@ -158,11 +159,11 @@ nix-build -A packages.x86_64-linux.jak-asan # package with Clang ASan build

### Required Software

We primarily use Visual Studio for development on Windows for C++ development. Download the community addition from [here](https://visualstudio.microsoft.com/vs/)
We primarily use Visual Studio on Windows for C++ development. Download the community edition from [here](https://visualstudio.microsoft.com/vs/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna specify 2022 perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll specify the latest release so we won't have to update the docs and just make sure it functions on the latest version.

@xTVaser xTVaser marked this pull request as draft February 13, 2022 23:57
@xTVaser xTVaser marked this pull request as ready for review February 14, 2022 02:22
@xTVaser
Copy link
Member Author

xTVaser commented Feb 14, 2022

Tested on WSL, i was able to fully build and run the game using the steps in the README (so fast as well)

Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@water111 water111 merged commit 70fcb05 into open-goal:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants