Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Support escape codes for any character #125

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

water111
Copy link
Collaborator

Game text has weird non-printable characters that the reader can't handle. Now you can do something like "\cab" and it will insert the character for 0xab. This involves fiddling with the string to number and number to string stuff, which is always a pain on Windows so I'm making this a separate PR for testing.

@water111
Copy link
Collaborator Author

coveralls didn't work.

@water111 water111 merged commit ae05387 into master Nov 17, 2020
@water111 water111 deleted the w/escaped-strings-in-reader branch November 17, 2020 20:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 368882654

  • 55 of 56 (98.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 81.28%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/goos/Reader.cpp 40 41 97.56%
Totals Coverage Status
Change from base Build 367153026: 0.04%
Covered Lines: 16052
Relevant Lines: 19749

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants