Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading streaming data in decompiler #130

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

water111
Copy link
Collaborator

It turns out streaming data in Jak 1 is implemented as a bunch of chunks. Each chunk is a GOAL object file. This PR adds the StrFileReader utility for reading and extracting GOAL objects from a streaming data file, adds support for STR files to the decompiler, and adds all STR files to the object map and decompiler config. There were no duplicate names, so naming was simple and there is no name remapping.

These chunks don't store an easy to understand name, so the utility also can extract the full name. For example, the file GRSOBBA is actually an abbreviation of green-sagecage-outro-beat-boss-a. We also test that we can correctly abbreviate animation names using the stupidly complicated Animation Name system.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 376512989

  • 7 of 82 (8.54%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 81.288%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/util/FileUtil.cpp 7 82 8.54%
Totals Coverage Status
Change from base Build 376336350: -0.3%
Covered Lines: 16590
Relevant Lines: 20409

💛 - Coveralls

@water111 water111 merged commit 66c9f40 into master Nov 21, 2020
@water111 water111 deleted the w/str-data-in-decompiler branch November 21, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants