some fixes #1308
Merged
some fixes #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
approved these changes
Apr 15, 2022
goal_src/goal-lib.gc
Outdated
| ) | ||
| ) | ||
| ) | ||
|
|
||
| (defmacro awhen (condition &rest body) | ||
| "Anaphoric when, similar to Common Lisp" |
There was a problem hiding this comment.
thanks dictionary, this makes it more clear
There was a problem hiding this comment.
Lol, this is what I found first http://community.schemewiki.org/?anaphoric-if
There was a problem hiding this comment.
(I don't think "anaphoric when" is a lisp thing, only "anaphoric if", so I'm kind of cheating)
| if (all_unique_names.find(name) != all_unique_names.end() && | ||
| merged_objs.find(name) == merged_objs.end()) { | ||
| lg::error("Object file {} appears multiple times with the same name.", name); | ||
| } | ||
| if (merged_objs.find(name) == merged_objs.end() || |
| @@ -35,7 +36,7 @@ class Serializer { | |||
| * later be accessed with get_save_result. | |||
| */ | |||
| Serializer() : m_writing(true) { | |||
| const size_t initial_size = 32; | |||
| constexpr size_t initial_size = 32 * 1024 * 1024; | |||
There was a problem hiding this comment.
I think I have a better fix for this. There's a silly bug so it resizes on every addition 🤦♂️
There was a problem hiding this comment.
but this is fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelWithDebInfobuild for windows-clang