Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the STR RPC to overlord and game code #134

Merged
merged 8 commits into from
Nov 22, 2020
Merged

Conversation

water111
Copy link
Collaborator

The STR RPC is used to load animation and game text. It requires adding an additional RPC thread to OVERLORD, and support for it in GOAL. Most of the complicated stuff on the IOP side is already done for the other RPCs, so this is mostly adding support on the GOAL side.

@coveralls
Copy link

coveralls commented Nov 22, 2020

Pull Request Test Coverage Report for Build 377597579

  • 58 of 108 (53.7%) changed or added relevant lines in 10 files are covered.
  • 79 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.5%) to 80.865%

Changes Missing Coverage Covered Lines Changed/Added Lines %
game/overlord/iso.cpp 9 10 90.0%
common/util/FileUtil.cpp 3 5 60.0%
game/overlord/iso_api.cpp 4 18 22.22%
game/overlord/stream.cpp 21 54 38.89%
Files with Coverage Reduction New Missed Lines %
game/kernel/klink.cpp 1 74.63%
game/kernel/kmalloc.cpp 1 46.58%
game/overlord/isocommon.cpp 3 30.68%
game/kernel/kscheme.cpp 18 64.23%
game/kernel/fileio.cpp 21 54.36%
game/sce/sif_ee.cpp 35 50.5%
Totals Coverage Status
Change from base Build 377574893: -0.5%
Covered Lines: 16629
Relevant Lines: 20564

💛 - Coveralls

@water111 water111 marked this pull request as ready for review November 22, 2020 17:59
@water111 water111 merged commit 19b8bb8 into master Nov 22, 2020
@water111 water111 deleted the w/overlord-streaming branch November 22, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants