Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompiler] Begin ir2 form implementation #197

Merged
merged 4 commits into from
Jan 17, 2021
Merged

[Decompiler] Begin ir2 form implementation #197

merged 4 commits into from
Jan 17, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Jan 17, 2021

Some random thoughts:

  • Look at how to pack in the old IR_Atomic info. (std::optional<AtomicInfo>?)
  • Look at how to map atomic op idx to FormElements? Or how will we do variable scoping?
  • How to get all variables that are used?
  • Regression tests (offline)
  • Make sure it runs even if we don't have type info

@water111 water111 marked this pull request as draft January 17, 2021 01:49
@coveralls
Copy link

coveralls commented Jan 17, 2021

Pull Request Test Coverage Report for Build 492314448

  • 5 of 1216 (0.41%) changed or added relevant lines in 10 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.6%) to 55.436%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/AtomicOpTypeAnalysis.cpp 0 3 0.0%
decompiler/IR2/AtomicOp.h 0 14 0.0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 22 0.0%
decompiler/Function/CfgVtx.cpp 0 26 0.0%
decompiler/IR2/AtomicOpForm.cpp 0 35 0.0%
decompiler/IR2/Form.h 0 70 0.0%
decompiler/IR2/Form.cpp 0 373 0.0%
decompiler/IR2/cfg_builder.cpp 0 668 0.0%
Files with Coverage Reduction New Missed Lines %
decompiler/Function/CfgVtx.h 1 0%
decompiler/IR2/AtomicOpTypeAnalysis.cpp 1 0%
decompiler/IR2/AtomicOp.h 2 55.56%
Totals Coverage Status
Change from base Build 490254738: -1.6%
Covered Lines: 21766
Relevant Lines: 39263

💛 - Coveralls

@water111 water111 marked this pull request as ready for review January 17, 2021 22:46
@water111 water111 mentioned this pull request Jan 17, 2021
28 tasks
@water111 water111 merged commit d6bbca5 into master Jan 17, 2021
@water111 water111 deleted the w/ir2-form branch January 17, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants