Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompiler] Test framework for decompiler regression tests and gcommon tests #200

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

water111
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 18, 2021

Pull Request Test Coverage Report for Build 494266819

  • 226 of 246 (91.87%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+7.1%) to 62.568%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/Form.cpp 0 1 0.0%
decompiler/ObjectFile/LinkedObjectFile.cpp 4 5 80.0%
decompiler/Function/TypeAnalysis.cpp 1 5 20.0%
test/decompiler/test_FormRegression.cpp 197 202 97.52%
decompiler/IR2/variable_naming.cpp 18 27 66.67%
Files with Coverage Reduction New Missed Lines %
decompiler/IR2/variable_naming.cpp 1 71.56%
Totals Coverage Status
Change from base Build 492330847: 7.1%
Covered Lines: 24712
Relevant Lines: 39496

💛 - Coveralls

@water111
Copy link
Collaborator Author

Having this type of test seems very valuable, and I already found a few bugs when creating this. The biggest issue with these tests is it's really confusing to understand the output before all the expression stuff has been properly built (stuff like "hidden variables" set in branch delay slots, the ordering of body/condition in loops, etc). But I think it's still worth it to come up with a set of test functions that we can test at various points in the decompiler, and it will only get easier to add more tests as the decompiler progresses.

@water111 water111 mentioned this pull request Jan 18, 2021
28 tasks
@water111 water111 marked this pull request as ready for review January 18, 2021 18:13
@water111 water111 changed the title [Decompiler] Test framework for decompiler regression tests [Decompiler] Test framework for decompiler regression tests and gcommon tests Jan 18, 2021
@water111 water111 merged commit 40d328f into master Jan 18, 2021
@water111 water111 deleted the w/ir2-regression-tests branch January 18, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants