Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompiler] Begin expression conversion, rearrange tests #209

Merged
merged 4 commits into from
Jan 23, 2021

Conversation

water111
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 506337060

  • 555 of 632 (87.82%) changed or added relevant lines in 18 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 65.72%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/Function/TypeAnalysis.cpp 1 2 50.0%
decompiler/IR2/FormStack.cpp 10 11 90.91%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 1 0.0%
decompiler/analysis/expression_build.cpp 14 18 77.78%
test/decompiler/FormRegressionTest.cpp 81 86 94.19%
decompiler/IR2/FormExpressionAnalysis.cpp 108 116 93.1%
decompiler/IR2/Form.cpp 28 85 32.94%
Files with Coverage Reduction New Missed Lines %
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 1 0%
goalc/listener/Listener.cpp 1 84.19%
Totals Coverage Status
Change from base Build 505130709: 0.07%
Covered Lines: 24961
Relevant Lines: 37981

💛 - Coveralls

@water111 water111 marked this pull request as ready for review January 23, 2021 21:28
@water111 water111 changed the title [Decompiler] Begin expression conversion [Decompiler] Begin expression conversion, rearrange tests Jan 23, 2021
@water111
Copy link
Collaborator Author

I ended up rearranging a bunch of test stuff instead of doing much work on expressions. Merging this as a separate PR so the expression stuff is easier to look at.

@water111 water111 merged commit 27f0a7c into master Jan 23, 2021
@water111 water111 deleted the w/expression-conversion branch January 23, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants