Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompiler] Expression 5 #218

Merged
merged 16 commits into from
Feb 2, 2021
Merged

[Decompiler] Expression 5 #218

merged 16 commits into from
Feb 2, 2021

Conversation

water111
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 27, 2021

Pull Request Test Coverage Report for Build 529432522

  • 679 of 946 (71.78%) changed or added relevant lines in 27 files are covered.
  • 24 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.6%) to 67.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/FormStack.cpp 14 17 82.35%
decompiler/analysis/expression_build.cpp 0 3 0.0%
decompiler/config.cpp 0 3 0.0%
decompiler/IR2/AtomicOp.cpp 32 38 84.21%
decompiler/IR2/AtomicOpTypeAnalysis.cpp 8 14 57.14%
decompiler/ObjectFile/ObjectFileDB.cpp 0 6 0.0%
goalc/compiler/compilation/Function.cpp 18 25 72.0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 10 0.0%
decompiler/IR2/FormExpressionAnalysis.cpp 247 264 93.56%
decompiler/IR2/AtomicOpForm.cpp 82 105 78.1%
Files with Coverage Reduction New Missed Lines %
decompiler/analysis/expression_build.cpp 1 92.31%
decompiler/ObjectFile/ObjectFileDB.cpp 1 0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 1 0%
decompiler/IR2/Env.cpp 2 16.08%
decompiler/IR2/FormExpressionAnalysis.cpp 2 94.73%
decompiler/IR2/AtomicOp.cpp 5 67.86%
decompiler/IR2/Form.cpp 12 73.02%
Totals Coverage Status
Change from base Build 516765230: 0.6%
Covered Lines: 26972
Relevant Lines: 40138

💛 - Coveralls

@water111
Copy link
Collaborator Author

water111 commented Feb 1, 2021

Before merging this:

  • Empty list of allowed object files
  • stupid labels at the top for the test input
  • type hints show up as casts in the output
  • test final output stuff

@water111 water111 marked this pull request as ready for review February 2, 2021 01:39
@water111 water111 merged commit a870bb5 into master Feb 2, 2021
@water111 water111 deleted the w/expressions-5 branch February 2, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants