Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompilation] Fixes to compiler/decompiler for gcommon #227

Merged
merged 14 commits into from
Feb 6, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Feb 3, 2021

No description provided.

@coveralls
Copy link

coveralls commented Feb 3, 2021

Pull Request Test Coverage Report for Build 542004821

  • 285 of 364 (78.3%) changed or added relevant lines in 14 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 67.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/analysis/cfg_builder.cpp 0 1 0.0%
decompiler/analysis/variable_naming.cpp 7 8 87.5%
tools/dgo_unpacker.cpp 0 1 0.0%
test/decompiler/FormRegressionTest.cpp 10 12 83.33%
goalc/compiler/compilation/Math.cpp 21 24 87.5%
decompiler/IR2/AtomicOpForm.cpp 4 8 50.0%
decompiler/IR2/FormStack.cpp 9 13 69.23%
decompiler/IR2/Form.cpp 19 25 76.0%
decompiler/IR2/FormExpressionAnalysis.cpp 196 253 77.47%
Files with Coverage Reduction New Missed Lines %
decompiler/IR2/FormStack.cpp 1 73.58%
decompiler/IR2/FormExpressionAnalysis.cpp 16 87.47%
Totals Coverage Status
Change from base Build 541457656: 0.3%
Covered Lines: 27672
Relevant Lines: 40772

💛 - Coveralls

@water111 water111 marked this pull request as ready for review February 6, 2021 00:35
@water111 water111 merged commit ddffda1 into master Feb 6, 2021
@water111 water111 deleted the w/decompiler-gcommon-fixes branch February 6, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants