Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asize bug, decompile a few files #293

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Feb 28, 2021

Changes a bug where (asize-of x) returns the wrong thing for objects of types which did not define their own asize-of method and instead inherited from basic.

Fix regression from #292 where the decompiler would abort when it had an error.

Improve printing of data decompilation.

Decompile a few files, pat-h surface-h. Started on fact-h.

@coveralls
Copy link

coveralls commented Feb 28, 2021

Pull Request Test Coverage Report for Build 608729187

  • 18 of 20 (90.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 2 0.0%
Totals Coverage Status
Change from base Build 608220196: 0.02%
Covered Lines: 30921
Relevant Lines: 44824

💛 - Coveralls

@water111 water111 merged commit 9d3b056 into master Feb 28, 2021
@water111 water111 deleted the w/decomp-and-asize-bug-fix branch February 28, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants