repl: Support cross-session history #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linenoise had all the tools already to support this, the problem (and i could very well have solved it in a less than ideal way) is that the history is stored in a
static
vector. Being as we have to interact with the history in different points of the app (ie, load the history on startup / save it on exit / etc) these are all in different files, and when doing so the history would be empty.Wrapping everything to have a single linenoise include, "solves" this problem, and history now works as expected.
It will save a
.opengoal.repl.history
file in your (linux)$HOME
or (windows)$USERPROFILE
directory.