Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompiler] Decompile let #309

Merged
merged 4 commits into from
Mar 5, 2021
Merged

[Decompiler] Decompile let #309

merged 4 commits into from
Mar 5, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Mar 5, 2021

Todo before merge:

  • Update the offline test reference
  • Fix up missing parent issue for gkernel
  • Make decompiler regression tests use this pass
  • Recognize dotimes (this PR is getting long, will do this later)

@coveralls
Copy link

coveralls commented Mar 5, 2021

Pull Request Test Coverage Report for Build 625993317

  • 355 of 402 (88.31%) changed or added relevant lines in 13 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 68.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/config.cpp 0 1 0.0%
test/offline/offline_test_main.cpp 0 1 0.0%
decompiler/IR2/Env.cpp 10 12 83.33%
decompiler/analysis/insert_lets.h 0 4 0.0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 15 0.0%
decompiler/IR2/Form.cpp 166 190 87.37%
Files with Coverage Reduction New Missed Lines %
decompiler/analysis/final_output.cpp 1 17.68%
decompiler/IR2/Env.cpp 1 53.04%
decompiler/IR2/Form.cpp 1 77.38%
goalc/listener/Listener.cpp 3 84.97%
Totals Coverage Status
Change from base Build 621504658: 0.2%
Covered Lines: 31502
Relevant Lines: 45726

💛 - Coveralls

@water111 water111 merged commit 65ffe83 into master Mar 5, 2021
@water111 water111 deleted the w/fix-gcommon-2 branch March 5, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants