Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement runtime display (test) #318

Merged
merged 20 commits into from
Mar 10, 2021
Merged

Conversation

ManDude
Copy link
Member

@ManDude ManDude commented Mar 9, 2021

Implements a display window using GLFW and OpenGL (using glad).

There is currently a bug where manually closing the display window will cause some issues with the listener check. I don't really know how to fix them.

@coveralls
Copy link

coveralls commented Mar 10, 2021

Pull Request Test Coverage Report for Build 637993704

  • 15 of 76 (19.74%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 68.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
game/runtime.cpp 7 10 70.0%
game/system/SystemThread.cpp 0 5 0.0%
game/graphics/gfx.h 0 10 0.0%
game/graphics/gfx.cpp 0 19 0.0%
game/graphics/display.cpp 0 24 0.0%
Totals Coverage Status
Change from base Build 631146389: -0.08%
Covered Lines: 31757
Relevant Lines: 46409

💛 - Coveralls

@ManDude ManDude marked this pull request as ready for review March 10, 2021 01:56
@ManDude
Copy link
Member Author

ManDude commented Mar 10, 2021

The system works perfectly now. The runtime is ready to have actual graphics rendered in it, and handling user input.

@water111 water111 merged commit 9430b47 into open-goal:master Mar 10, 2021
@ManDude ManDude deleted the opengl-glfw-test branch March 10, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants