Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g/j2: workaround intermittent lifeseed DMA crash #3418

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Mar 9, 2024

This is not a fix, but it temporarily works around the potential crash discussed here #2988

As long as this doesn't impact other things, this feels like a good interim fix, as having a broken cutscene is better than a fatal crash and it might be some time before this is properly identified and fixed.

@xTVaser
Copy link
Member Author

xTVaser commented Mar 10, 2024

macOS tests seems to often intermittently crash over exit code 132 now after updating from 11 to 12?

Seemingly no logs to shed light on the problem, but i did see this (which also happens on successful runs...):

Warning: /Users/runner/work/jak-project/jak-project/third-party/googletest/googletest/src/gtest-death-test.cc:1124:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads. See https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

@xTVaser xTVaser merged commit 937af79 into open-goal:master Mar 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants