Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL related improvements and fixes #3545

Merged
merged 8 commits into from
Jun 3, 2024
Merged

REPL related improvements and fixes #3545

merged 8 commits into from
Jun 3, 2024

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Jun 2, 2024

Motivated by - open-goal/opengoal-vscode#358

This addresses the following:

  • Fixes closing target after connecting subtitle editor causes REPL spam #2939 spam edge-case
  • Stop picking a different nREPL port based on the game mode by default, this causes friction for tools in the average usecase (having a REPL open for a single game, and wanting to connect to it). goalc spins up fine even if the port is already bound to.
    • For people that need/want this behaviour, adding per-game configuration to the repl-config.json is on my todo list.
  • Allows goalc to permit redefining symbols, including functions. This is defaulted to off via the repl-config.json but it allows you to for example, change the definition of a function without having to restart and rebuild the entire game.
    Screenshot 2024-06-02 124558
  • Updates the welcome message to include a bunch of useful metadata up-front. Cleaned up all the startup logs that appear when starting goalc, many of whom's information is now included in the welcome message.
    • Before:
      image

    • After:
      Screenshot 2024-06-01 235954

@xTVaser xTVaser merged commit eb703ee into master Jun 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

closing target after connecting subtitle editor causes REPL spam
1 participant