Update volume in sound-group sog3 to sfx-volume #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hat-Kid
requested changes
Jul 8, 2024
This reverts commit c6fc702.
l😂 |
Zedb0T
changed the title
Hat-Kid
approved these changes
Jul 8, 2024
goal_src/jak1/pc/progress-pc.gc
Outdated
| @@ -2906,7 +2906,7 @@ | |||
| ;; override the enter handler for progress-going-out | |||
| (set! (-> progress-going-out enter) | |||
| (lambda :behavior progress () | |||
| (sound-play "menu-close") | |||
| (sound-play "menu-close" :vol (-> *setting-control* default sfx-volume)) ;; og:preserve-this Make this sound respect sfx setting | |||
There was a problem hiding this comment.
Don't need a preserve-this comment because the pc files are not touched by the decompiler, but not a big deal if it stays.
There was a problem hiding this comment.
Can clean it up while I'm here but yeah, skip preserves in files that aren't generated by the decompiler makes sense whoops.
Zedb0T
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to override certain sounds that don't respect the settings that they should...
8mb.video-8ue-Vmxcmr5f.mp4