Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decompile] vector.gc (finally) #394

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Conversation

water111
Copy link
Collaborator

I think we now have everything to decompile vector.gc.

Current this is about half of it + tests. Everything out of the decompiler seems to be correct. Most of the work is figuring out their crazy naming conventions (what does vector-v*float++! mean??) and writing reasonable doc strings.

@coveralls
Copy link

coveralls commented Apr 28, 2021

Pull Request Test Coverage Report for Build 794000005

  • 34 of 34 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 69.247%

Totals Coverage Status
Change from base Build 790847500: 0.02%
Covered Lines: 34118
Relevant Lines: 49270

💛 - Coveralls

@water111
Copy link
Collaborator Author

vector-cross! will return junk in w - need to update the tests to not print this.

@water111 water111 marked this pull request as ready for review April 28, 2021 21:03
@water111 water111 linked an issue Apr 28, 2021 that may be closed by this pull request
@water111 water111 merged commit 14028b9 into master Apr 28, 2021
@water111 water111 deleted the w/decompile-vector-for-real branch April 28, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compiler] Vector float to int rounding differs from PS2
2 participants