Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decompiler] small fixes for methods and more reference tests #419

Merged
merged 2 commits into from
May 6, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented May 6, 2021

The methods-by-name hack is gone! This fixes some engine function that was failing before.
Also fixed an issue where bitfield/enum constants weren't decompiler if they appeared directly in arguments and the return type of the new method of an object that inherited its new method from basic.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 815390179

  • 64 of 75 (85.33%) changed or added relevant lines in 7 files are covered.
  • 45 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.08%) to 69.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/Form.cpp 14 15 93.33%
decompiler/IR2/GenericElementMatcher.cpp 11 12 91.67%
test/offline/offline_test_main.cpp 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
decompiler/IR2/FormExpressionAnalysis.cpp 1 80.95%
game/overlord/iso.cpp 1 77.86%
decompiler/IR2/Form.h 3 92.8%
decompiler/IR2/GenericElementMatcher.cpp 40 57.1%
Totals Coverage Status
Change from base Build 814852033: -0.08%
Covered Lines: 34262
Relevant Lines: 49510

💛 - Coveralls

@water111 water111 merged commit 21fefa0 into master May 6, 2021
@water111 water111 deleted the w/decompiler-method-name branch May 6, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants