Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decompiler] Clean up config more #458

Merged
merged 2 commits into from
May 12, 2021
Merged

[decompiler] Clean up config more #458

merged 2 commits into from
May 12, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented May 12, 2021

This removes the global config finally! It also splits up the main config into an inputs/hacks file to keep the main config a little bit shorter.

Also the big offline test script was revived which will now test:

  • cloning
  • building everything
  • unit tests
  • offline decompiler tests
  • full decompilation (just checks it doesn't crash)
  • asset building
  • asset checking (compare against game)
  • game building
  • boot game

@water111 water111 linked an issue May 12, 2021 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 833657923

  • 0 of 124 (0.0%) changed or added relevant lines in 8 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 69.223%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/Function/TypeInspector.cpp 0 1 0.0%
decompiler/ObjectFile/LinkedObjectFile.cpp 0 1 0.0%
decompiler/ObjectFile/LinkedObjectFileCreation.cpp 0 3 0.0%
test/offline/offline_test_main.cpp 0 15 0.0%
decompiler/ObjectFile/ObjectFileDB.cpp 0 17 0.0%
decompiler/main.cpp 0 21 0.0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 31 0.0%
decompiler/config.cpp 0 35 0.0%
Files with Coverage Reduction New Missed Lines %
decompiler/main.cpp 2 0%
decompiler/ObjectFile/ObjectFileDB.cpp 2 0%
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 2 0%
test/offline/offline_test_main.cpp 2 0%
Totals Coverage Status
Change from base Build 833478093: 0.0%
Covered Lines: 34266
Relevant Lines: 49501

💛 - Coveralls

@water111 water111 merged commit 0599d14 into master May 12, 2021
@water111 water111 deleted the w/remove-global-config branch May 12, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[decompiler] Remove global config object
2 participants