decomp: mood-tables
#460
Merged
decomp: mood-tables
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
reviewed
May 12, 2021
| ;; definition for function make-light-kit | ||
| (defun | ||
| make-light-kit | ||
| ((arg0 light-group) (arg1 float) (arg2 float) (arg3 float) (arg4 float)) |
There was a problem hiding this comment.
I like to put all these on the same line:
(defun make-light-kit ((arg0 light-group) (arg1 float) (arg2 float) (arg3 float) (arg4 float))
Not a huge deal, but having the name on the same line as defun makes it easier to search for defun make-light-kit.
| (let ((s4-0 (new 'stack-no-clear 'matrix))) | ||
| (matrix-rotate-y! s4-0 arg1) | ||
| (let ((v1-0 (-> arg0 dir0))) | ||
| (set! (-> v1-0 direction x) (l.f L87)) |
There was a problem hiding this comment.
You'll need to add these labels to label_types.json, until I get around to fixing #461. These are just floats.
|
|
||
| ;; definition for symbol *default-interp-table*, type sky-color-day | ||
| (define | ||
| *default-interp-table* |
There was a problem hiding this comment.
I'd recommend putting define and *default-interp-table* on the same line here and in all the other defines.
Pull Request Test Coverage Report for Build 834028438
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
level-infothis doesn't contain the weirdquote'ing behaviour, hopefully this passes CI successfully.