Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(init-vf0-vector) to make vector code a bit more readable #494

Merged
merged 4 commits into from
May 16, 2021

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented May 16, 2021

After some discussion, we are probably abandoning #445 because we can't really get it to performance any better. From Agner Fog's writings:

There is no instruction for moving a constant into avector register. The default way of putting a constant into a vectorregister is to load it from a memory constant. This is also the most efficient way if cache misses are rare. But if cache misses are frequent then we may look for alternatives

But we can atleast make it a bit more readable, turns out i already had a TODO around this anyway.

I'm not sure if i defined the macro in the write place, because i then had to put it in the forward-declarations for tests to pass.

@coveralls
Copy link

coveralls commented May 16, 2021

Pull Request Test Coverage Report for Build 847395773

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0006%) to 69.179%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/Form.cpp 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
game/system/iop_thread.cpp 1 96.08%
Totals Coverage Status
Change from base Build 845942068: -0.0006%
Covered Lines: 34433
Relevant Lines: 49774

💛 - Coveralls

@@ -0,0 +1,14 @@
(defun test-vector-constant ()
(let ((vector-1 (new 'stack 'vector)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, was a left over when i was testing the new ASM instructions that have been decided against.

@water111 water111 merged commit b75a64f into open-goal:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants