New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decomp: decompile `trajectory` #499

Merged

water111 merged 3 commits into open-goal:master from xTVaser:decomp/trajectory

May 19, 2021

Member

xTVaser commented May 17, 2021

I'm pretty confident about the signature for add-debug-line but might be worth an extra pair of eyes.


          decomp: decompile trajectory

2c39ecc

coveralls commented May 17, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 855283245

0 of 0 changed or added relevant lines in 0 files are covered.
240 unchanged lines in 11 files lost coverage.
Overall coverage increased (+0.09%) to 69.271%

Files with Coverage Reduction	New Missed Lines	%
common/type_system/deftype.cpp	2	81.94%
goalc/compiler/compilation/Define.cpp	2	93.13%
test/goalc/test_with_game.cpp	3	98.6%
goalc/compiler/compilation/Atoms.cpp	6	93.28%
goalc/compiler/Compiler.h	12	40.74%
goalc/compiler/Val.cpp	12	89.82%
common/type_system/defenum.cpp	14	79.52%
goalc/compiler/Val.h	20	72.84%
goalc/compiler/compilation/Type.cpp	45	90.74%
common/type_system/TypeSystem.cpp	53	72.62%

Totals
Change from base Build 848129577:	0.09%
Covered Lines:	34569
Relevant Lines:	49904

💛 - Coveralls

water111 reviewed

View reviewed changes

Collaborator

water111 left a comment

I think add-debug-line might not be right but everything else looks good

goal_src/engine/physics/trajectory.gc Outdated

+                        )
+                   (let ((t2-0 -1))
+                    )
+                   (t9-1 a0-6 a1-1 a2-1 a3-0 (the-as int t0-0) t1-0)

Collaborator

water111 May 17, 2021

based on the code here, i'd guess that add-debug-line takes one more argument (possibly unused inside the function).
If you try that, does this get a lot nicer?

goal_src/engine/physics/trajectory.gc Outdated

+                        (a1-1 68)
+                        (a2-1 s5-0)
+                        (a3-0 s4-0)
+                        (t0-0 #x800000ff)

Collaborator

water111 May 17, 2021

This looks like a rgba color to me. If you change the type of add-debug-line to make this argument an rgba, it should convert this to (new 'static 'rgba :r #xff :a #x80) automatically.

goal_src/engine/physics/trajectory.gc Outdated

+              ;; Used lq/sq
+              (defmethod TODO-RENAME-15 trajectory ((obj trajectory))
+                (let ((s5-0 (new 'stack-no-clear 'trajectory))
+                      (s4-0 (new 'stack-no-clear 'trajectory))

Collaborator

water111 May 17, 2021

I'm guessing these are vector instead of trajectory?

decompiler/config/all-types.gc Show resolved Hide resolved

xTVaser force-pushed the decomp/trajectory branch from cae30ba to 44a6682 Compare

May 18, 2021 02:09


          address review feedback

44a6682

water111 reviewed

View reviewed changes

goal_src/engine/physics/trajectory.gc Outdated

+              (defmethod
+                TODO-RENAME-9
+                trajectory
+                ((obj trajectory) (arg0 float) (arg1 trajectory))

Collaborator

water111 May 18, 2021

I think arg1 here is a vector. Thie method does "evaluate trajectory at time arg0" and its output is just a vector for the point.

goal_src/engine/physics/trajectory.gc Outdated

+              (defmethod
+                TODO-RENAME-10
+                trajectory
+                ((obj trajectory) (arg0 float) (arg1 trajectory) (arg2 trajectory))

Collaborator

water111 May 18, 2021

I think arg1 is a vector and arg2 can be removed. This function computes the derivative of the trajectory and stores it in a vector (arg2).

goal_src/engine/physics/trajectory.gc Outdated

+                   ((method-of-type trajectory TODO-RENAME-9)
+                    obj
+                    f0-1
+                    (the-as trajectory s4-0)

Collaborator

water111 May 18, 2021

Casting a to a larger type (trajectory > vector) is a sign that something isn't quite right here. I think once you change the arguments on this method it will go away.


          some more corrections

b6615a2

water111 merged commit ce6ebc3 into open-goal:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet