Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically watch PCSX2 savestate directory and analyze the EE Memory #507

Merged
merged 4 commits into from
May 20, 2021

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented May 20, 2021

I can convert elzip to a submodule if desired, it's not too big though.

Usage:

task watch-pcsx2 SAVESTATE_DIR="PATH_TO_PCSX2_SAVESTATE_DIR"

Ideally run from the root of the repo

Everytime a save-state is saved, it will be processed and ee-analysis.log will be updated in the root of the repo

@coveralls
Copy link

coveralls commented May 20, 2021

Pull Request Test Coverage Report for Build 859198074

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 69.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/MemoryDumpTool/main.cpp 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
tools/MemoryDumpTool/main.cpp 1 0%
Totals Coverage Status
Change from base Build 858776013: -0.02%
Covered Lines: 34569
Relevant Lines: 50084

💛 - Coveralls

@water111
Copy link
Collaborator

Nice!

I think having a zip library available is a good idea.

I'm not a huge fan of the 11zip wrapper, but it sounds like it works and the minizip library it uses internally seems like a good choice, so lets go with this for now. If we ever compress assets (DGOs/textures compress really well!) we might want to revisit this.

@water111 water111 merged commit 9e2b49a into open-goal:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants