Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenGOAL] Support for 128-bit arguments and return values (WIP) #510

Merged
merged 2 commits into from
May 21, 2021
Merged

[OpenGOAL] Support for 128-bit arguments and return values (WIP) #510

merged 2 commits into from
May 21, 2021

Conversation

water111
Copy link
Collaborator

Checking to see if windows tests pass...

@coveralls
Copy link

coveralls commented May 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 862189893

  • 174 of 179 (97.21%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 69.088%
Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/compilation/Function.cpp 43 44 97.73%
goalc/compiler/compilation/Type.cpp 38 42 90.48%
Totals Coverage Status
Change from base Build 861964004: 0.07%
Covered Lines: 34672
Relevant Lines: 50185
💛 - Coveralls

@water111
Copy link
Collaborator Author

codacy failure is "scope of variable can be reduced" which is true, but I don't want to.

@water111 water111 marked this pull request as ready for review May 21, 2021 00:09
@water111 water111 merged commit 663b5c7 into master May 21, 2021
@water111 water111 deleted the w/new-calling-convention branch May 21, 2021 00:12
@water111 water111 mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@water111 @coveralls