[decomp] more of res + change a few macros
#527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 874767219
💛 - Coveralls |
xTVaser
reviewed
May 25, 2021
Comment on lines
23
to
+30
| "name": "Release", | ||
| "generator": "Ninja", | ||
| "configurationType": "RelWithDebInfo", | ||
| "configurationType": "Release", | ||
| "buildRoot": "${projectDir}\\out\\build\\${name}", | ||
| "installRoot": "${projectDir}\\out\\install\\${name}", | ||
| "cmakeCommandArgs": "", | ||
| "buildCommandArgs": "", | ||
| "addressSanitizerEnabled": true, | ||
| "addressSanitizerEnabled": false, |
There was a problem hiding this comment.
should we make a separate config to use in the windows CI build to still use ASan? or do we no longer care.
There was a problem hiding this comment.
I think it would be nice to have asan tests on windows still, but that can wait for later. We still have them under the clang linux build.
There was a problem hiding this comment.
I wasn't able to notice any difference with asan on/off for the github testing VM (that makes sense, 90% of the time is spent compiling and the tests take less than a minute) so it could probably be left on for those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.