Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomp: credits #533

Merged
merged 5 commits into from
Jun 6, 2021
Merged

decomp: credits #533

merged 5 commits into from
Jun 6, 2021

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented May 28, 2021

Decompiler output is mishandling the *font-work*

@coveralls
Copy link

coveralls commented Jun 2, 2021

Pull Request Test Coverage Report for Build 912428110

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.504%

Totals Coverage Status
Change from base Build 910815144: 0.0%
Covered Lines: 36177
Relevant Lines: 52050

💛 - Coveralls

@xTVaser xTVaser marked this pull request as ready for review June 2, 2021 05:00
@xTVaser xTVaser changed the title decomp: credits but there are still issues decomp: credits Jun 2, 2021
@@ -4885,7 +4885,7 @@
(define-extern *text-group-names* (array string))
(define-extern kheap type)
(define-extern *common-text-heap* kheap)
(define-extern *common-text* symbol)
(define-extern *common-text* game-text-info) ; TODO guess, but its definitely not just a symbol!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that one was my bad guess a long long time ago.

@water111 water111 merged commit c19bcd3 into open-goal:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants