Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Cleanup and Documentation #54

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Compiler Cleanup and Documentation #54

merged 7 commits into from
Sep 24, 2020

Conversation

water111
Copy link
Collaborator

Add documentation and do a lot of little cleanup things in the compiler. There's still some stuff to clean up after this but I want to save that until refactoring the Register vs emitter::Register and settable stuff.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 271329032

  • 185 of 211 (87.68%) changed or added relevant lines in 17 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 64.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/CompilerSettings.cpp 4 5 80.0%
goalc/compiler/compilation/Atoms.cpp 14 15 93.33%
goalc/compiler/compilation/Block.cpp 10 11 90.91%
goalc/compiler/Val.cpp 0 2 0.0%
goalc/compiler/Val.h 1 3 33.33%
common/type_system/TypeSystem.cpp 7 10 70.0%
goalc/compiler/compilation/CompilerControl.cpp 1 8 12.5%
goalc/compiler/compilation/Function.cpp 29 38 76.32%
Files with Coverage Reduction New Missed Lines %
goalc/compiler/compilation/Function.cpp 1 85.94%
goalc/regalloc/Allocator.cpp 5 79.63%
goalc/compiler/compilation/CompilerControl.cpp 6 53.19%
goalc/compiler/Val.h 7 52.24%
Totals Coverage Status
Change from base Build 262974948: 0.3%
Covered Lines: 14094
Relevant Lines: 21967

💛 - Coveralls

@water111 water111 merged commit 2d11e44 into master Sep 24, 2020
@water111 water111 deleted the w/compiler_cleanup branch September 24, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants