Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler/decompiler] Take the address of a variable #554

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Jun 3, 2021

So far:

  • Support taking the address of a variable in the compiler
  • Get the address is type analysis (todo - I forgot the pointer part)
  • Convert to (& var)

To do:

  • Allow overriding the type of a stack variable
  • Fix bug in type pass (pointer)

@water111 water111 marked this pull request as ready for review June 4, 2021 17:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 907069911

  • 124 of 186 (66.67%) changed or added relevant lines in 22 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 69.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/goos/Reader.cpp 1 2 50.0%
decompiler/analysis/anonymous_function_def.cpp 0 1 0.0%
goalc/compiler/IR.cpp 20 21 95.24%
decompiler/util/config_parsers.cpp 10 12 83.33%
goalc/regalloc/Allocator.cpp 27 29 93.1%
decompiler/IR2/Env.h 6 9 66.67%
decompiler/IR2/AtomicOpTypeAnalysis.cpp 7 11 63.64%
decompiler/analysis/type_analysis.cpp 5 9 55.56%
goalc/compiler/compilation/Type.cpp 12 16 75.0%
decompiler/IR2/Form.cpp 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
decompiler/IR2/AtomicOpTypeAnalysis.cpp 1 77.8%
Totals Coverage Status
Change from base Build 907056422: -0.02%
Covered Lines: 36131
Relevant Lines: 51867

💛 - Coveralls

@water111 water111 merged commit 542edfb into master Jun 4, 2021
@water111 water111 deleted the w/compiler-stack-vars branch June 4, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants