Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decompiler] bug fixes related to infinite loop CFGs, argument registers #622

Merged
merged 3 commits into from
Jun 24, 2021
Merged

[decompiler] bug fixes related to infinite loop CFGs, argument registers #622

merged 3 commits into from
Jun 24, 2021

Conversation

water111
Copy link
Collaborator

  • fix multi-block infinite loops
  • fix bug with argument registers
  • possibly fix bug with vector out of range when trying to call a method without a proper type
  • byte stack spills
  • ~1K not recognized as a format argument

@coveralls
Copy link

Pull Request Test Coverage Report for Build 966416666

  • 40 of 42 (95.24%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 69.359%
Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/analysis/variable_naming.cpp 20 21 95.24%
decompiler/util/DecompilerTypeSystem.cpp 1 2 50.0%
Totals Coverage Status
Change from base Build 958929503: 0.01%
Covered Lines: 36661
Relevant Lines: 52857
💛 - Coveralls

@water111 water111 merged commit 44f8ff6 into master Jun 24, 2021
@water111 water111 deleted the w/decompiler-stacku8-and-cfg branch June 24, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@water111 @coveralls