Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs that appear to fix all known use-def issues.
First, it fixes a bug where attempted structuring on the same vertex multiple times, resulting in env updates happening twice. Now these are cached. This was harmless but triggered error.
The second bug is a little more complicated. The structuring pass marks the
(set! x #f)
in the delay slot as not a def, and leaves the defs as the actual expressions that write. Of course, we may not find one in all cases because of move elimination.This standardizes on the last non-eliminated set, not in a delay slot, as the result variable to use for a
cond
without an else.We could possibly use something else if detecting this causes trouble, but this was easy to implement and easy to understand the debug output.