Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Form with goos::Object #64

Merged
merged 10 commits into from
Oct 4, 2020
Merged

Replace Form with goos::Object #64

merged 10 commits into from
Oct 4, 2020

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Oct 4, 2020

Add pretty printing to GOOS object, and replace all uses of the old Form with the new GOOS object.
Also fix the bug where the pretty printer gives up if it's not possible to achieve the desired line length.

Add a test for the pretty printer where we read the code in gcommon, pretty print, and read again.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 288289437

  • 307 of 357 (85.99%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.669%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/goos/PrettyPrinter.h 0 2 0.0%
goalc/regalloc/Allocator.cpp 0 2 0.0%
common/goos/PrettyPrinter.cpp 265 311 85.21%
Totals Coverage Status
Change from base Build 285918498: 0.09%
Covered Lines: 14542
Relevant Lines: 17806

💛 - Coveralls

@water111 water111 merged commit b102d22 into master Oct 4, 2020
@water111 water111 deleted the w/remove-form branch October 4, 2020 21:08
@water111 water111 mentioned this pull request Oct 4, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants