Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler crashes and improve return statements. #652

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Jun 30, 2021

  • Fix crash when non-ascii characters are entered in the REPL or a source file.
  • Fix crash when an empty cond statement is encountered. It is now an error.
  • GOAL kernel will detect when you try to run something with a stack in the scratchpad and move it to a fake scratchpad stack.
  • return statements in the decompiler will look nicer now.
  • Fix crashes in some uses of forward declared types
  • Allow decompiling arrays containing symbols

@coveralls
Copy link

coveralls commented Jun 30, 2021

Pull Request Test Coverage Report for Build 984615165

  • 28 of 54 (51.85%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 69.256%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/IR2/FormExpressionAnalysis.cpp 3 4 75.0%
decompiler/util/data_decompile.cpp 0 2 0.0%
goalc/compiler/SymbolInfo.h 0 3 0.0%
common/goos/Reader.cpp 20 28 71.43%
goalc/compiler/compilation/CompilerControl.cpp 0 12 0.0%
Totals Coverage Status
Change from base Build 984603576: -0.01%
Covered Lines: 37030
Relevant Lines: 53468

💛 - Coveralls

@water111 water111 merged commit 322a4ed into master Jun 30, 2021
@water111 water111 deleted the w/compiler-bug-fixes-return-fix branch July 23, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants