decomp: shadow

[xTVaser]

No description provided.

[water111]

It looks like there's a crash when this code is loaded. Maybe we haven't decompiled the file that creates *part-id-table* yet? You could try to find where it's defined and just add that part, or just comment this out for now (and maybe leave a comment near the top of the file so we don't forget this)

[xTVaser]

ah yeah we havn't. that's either sparticle or sparticle-launcher

[water111]

In order to prevent the crash, you'll need the actual define, not just a define-extern. The define-extern just tells the compiler the type of *part-id-table*, but doesn't actually store anything in the symbol. The top-level code in shadow attempts to modify *part-id-table*, which crashes because nothing has defined that symbol. The default value of a symbol is 0, and in OpenGOAL, the first 1 MB of memory after 0x0 is intentionally unmapped so it crashes when trying to set a value in *part-id-table*.

You can add this to sparticle-launcher.gc and it should fix the crash:

(define *part-id-table* (new 'global 'boxed-array sparticle-launcher 3584))
(define *part-group-id-table* (new 'global 'boxed-array sparticle-launch-group 1024))

[coveralls]

Pull Request Test Coverage Report for Build 1092496669

• 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.009%) to 68.109%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
decompiler/util/data_decompile.cpp	1	6	16.67%

Files with Coverage Reduction	New Missed Lines	%
goalc/listener/Listener.cpp	3	84.62%

Totals
Change from base Build 1092363797:	-0.009%
Covered Lines:	39295
Relevant Lines:	57694

---

💛 - Coveralls