decomp: finish path
#685
Merged
decomp: finish path
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
reviewed
Jul 10, 2021
goal_src/engine/nav/path.gc
Outdated
| (+! | ||
| f30-0 | ||
| (vector-vector-distance | ||
| (the-as vector (&+ (-> obj curve cverts) (* s5-0 16))) |
There was a problem hiding this comment.
Can you try changing cverts to an (inline-array vector)? I think this would clean up this stuff.
goal_src/engine/nav/path.gc
Outdated
| ;; definition for method 11 of type path-control | ||
| ;; Used lq/sq | ||
| (defmethod get-random-point path-control ((obj path-control) (arg0 vector)) | ||
| (with-pp (cond |
There was a problem hiding this comment.
The formatting of this will probably change with the PR I merged a few minutes ago.
goal_src/engine/nav/path.gc
Outdated
| (a2-2 (-> obj curve)) | ||
| (a3-1 (new 'static 'rgba :r #xff :g #x80 :a #x80)) | ||
| ) | ||
| (t9-4 a0-8 (the-as bucket-id a1-3) a2-2 a3-1) |
There was a problem hiding this comment.
I think we have the type of add-debug-curve2 wrong. The asm for this is:
lw t9, add-debug-curve2(s7)
daddiu a0, s7, #t
addiu a1, r0, 68
daddiu a2, gp, 12
ld a3, L79(fp)
or t0, s7, r0
jalr ra, t9
sll v0, ra, 0The or t0, s7, r0 is setting a 5th argument to #f. I think if you add a symbol argument to add-debug-curve2, this will decompile correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.