Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some warnings and add some extra integer tests #71

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Clean up some warnings and add some extra integer tests #71

merged 1 commit into from
Oct 10, 2020

Conversation

water111
Copy link
Collaborator

I think this should avoid all the warnings from inja.

I also added some more integer test cases because I'm paranoid about integer constants for some reason.

xTVaser
xTVaser approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@xTVaser xTVaser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors/warnings on linux, looks good to me
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 298533871

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 81.359%
Totals Coverage Status
Change from base Build 298512192: 1.4%
Covered Lines: 14564
Relevant Lines: 17901
💛 - Coveralls

@water111 water111 merged commit 119a975 into master Oct 10, 2020
@water111 water111 deleted the w/clean-up-warnings branch October 10, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xTVaser xTVaser xTVaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@water111 @coveralls @xTVaser