Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decomp] get started on entity #793

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[decomp] get started on entity #793

merged 1 commit into from
Aug 31, 2021

Conversation

water111
Copy link
Collaborator

Unfortunately we aren't quite ready to do this entire file, but I at least got it started and learned a lot about the entity/actor/camera/ambient system.

Here's a screenshot of the green sage's hut, with entity marks and visiblity.
image

@water111 water111 merged commit 34e8afa into master Aug 31, 2021
@water111 water111 deleted the w/decomp-entity branch August 31, 2021 15:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1186567302

  • 50 of 83 (60.24%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 64.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/compilation/Static.cpp 9 10 90.0%
game/system/newpad.cpp 0 2 0.0%
decompiler/util/data_decompile.cpp 7 12 58.33%
decompiler/IR2/bitfields.cpp 33 58 56.9%
Files with Coverage Reduction New Missed Lines %
decompiler/util/data_decompile.cpp 1 53.41%
goalc/listener/Listener.cpp 3 84.29%
Totals Coverage Status
Change from base Build 1179886176: -0.005%
Covered Lines: 39807
Relevant Lines: 61480

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants