Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goalc] Fix some small issues with float to int #799

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Sep 1, 2021

It turns out I did not read the manual close enough, and our behavior with floats/ints was not correct.

I think the only likely way this could have gone wrong is if you have code that does fpr -> gpr, then expects the fpr to sign extend and does a (64-bit) slt.

@water111 water111 linked an issue Sep 1, 2021 that may be closed by this pull request
10 tasks
@water111 water111 linked an issue Sep 1, 2021 that may be closed by this pull request
@water111 water111 merged commit ac30920 into master Sep 1, 2021
@water111 water111 deleted the w/compiler-bugs branch September 1, 2021 02:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1188258707

  • 15 of 19 (78.95%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 64.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/compilation/Function.cpp 1 3 33.33%
goalc/compiler/compilation/Type.cpp 1 3 33.33%
Totals Coverage Status
Change from base Build 1187989119: 0.003%
Covered Lines: 39837
Relevant Lines: 61754

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[compiler] Fix moving floats into 64-bit and 128-bit registers General Compiler Robustness to Bad Input
2 participants