Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more array stuff and clean up field access #80

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Add more array stuff and clean up field access #80

merged 2 commits into from
Oct 14, 2020

Conversation

water111
Copy link
Collaborator

The new operator now can create arrays and inline arrays on heaps, as required for #49

Field access is split into a separate function with comments.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 307001075

  • 61 of 66 (92.42%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 81.536%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/goos/Object.h 3 4 75.0%
goalc/compiler/compilation/Type.cpp 46 50 92.0%
Totals Coverage Status
Change from base Build 301140291: 0.3%
Covered Lines: 14652
Relevant Lines: 17970
💛 - Coveralls

@water111 water111 merged commit 3616b79 into master Oct 14, 2020
@water111 water111 deleted the w/new-arrays branch October 14, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@water111 @coveralls