decomp: a few files that were done except for sp-launch-group
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
approved these changes
Sep 1, 2021
|
|
||
| ;; definition for method 7 of type beach-rock | ||
| ;; INFO: Return type mismatch none vs beach-rock. | ||
| (defmethod relocate beach-rock ((obj beach-rock) (arg0 int)) |
There was a problem hiding this comment.
There is now a special case in the decompiler for relocate methods that should hopefully remove the need for tons of casts. Let me know if these are still tedious and I can take a look and make sure it is working.
| ((v0-1 | ||
| ((the-as | ||
| (function res-lump symbol symbol float structure (pointer res-tag) pointer object) | ||
| (method-of-type res-lump get-property-struct) |
There was a problem hiding this comment.
hm, this looks weird. Can you try again without a cast here? It should get turned into a res-lump-struct macro now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dark-eco-poolbeach-rocksassistantminers