Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decomp: another batch of easy files #823

Merged
merged 11 commits into from
Sep 6, 2021
Merged

decomp: another batch of easy files #823

merged 11 commits into from
Sep 6, 2021

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Sep 3, 2021

  • sharkey
  • lurkercrab
  • lurkerpuppy
  • assistant-citadel
  • static-screen(demo-obs blocked by annoying handle casts, wait for that to be cleaned up in the future)
  • robotboss-h (i likely got some types wrong here)
  • light-eco (theres an event handler that crashes the compiler)
  • final-door
  • aphid

water111
water111 requested changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments on types

goal_src/levels/beach/lurkercrab.gc Outdated
'generic
)
)
(let ((t9-2 (method-of-object (-> obj collide-info) dummy-55)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this method is missing argument types

goal_src/levels/beach/lurkercrab.gc
(go (method-of-object obj nav-enemy-die))
)
((= v1-1 'punch)
(the-as none (cond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this (the-as none isn't great. I may need to work on the decompiler a bit to make this work properly. But this shouldn't block this PR from merging.

goal_src/levels/common/sharkey.gc Outdated
)
(set-vector! (-> obj draw color-mult) f0-2 f0-2 f0-2 1.0)
)
((method-of-object (-> obj water) dummy-10))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing method arguments

goal_src/levels/common/sharkey.gc Outdated
(* (-> self y-speed) (-> *display* seconds-per-frame))
)
)
((method-of-object (-> self water) dummy-10))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing method args

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1207023156

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 64.398%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test/offline/offline_test_main.cpp 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
goalc/listener/Listener.cpp 3 84.29%
Totals Coverage Status
Change from base Build 1206929779: -0.005%
Covered Lines: 39864
Relevant Lines: 61903
💛 - Coveralls

@water111 water111 merged commit d1f16b3 into open-goal:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@water111 water111 water111 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xTVaser @coveralls @water111