-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decomp: finish _almost all of_ the remaining camera code #845
Conversation
Updated submodule third-party/googletest
4ac8bc8
to
e0bf29e
Compare
Pull Request Test Coverage Report for Build 1350314599
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed up to cam-state-dbg.gc
decompiler/config/all-types.gc
Outdated
@@ -10338,11 +10338,12 @@ | |||
;; - Types | |||
|
|||
(deftype pov-camera (process-drawable) | |||
((flags int32 :offset-assert 176) | |||
((cspace-array cspace-array :offset 112) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. It really seems like children of process-drawable
can customize root
to be whatever they want. I wonder if there was a built in language feature for this that we are missing in OpenGOAL. None of these show up in inspect method, so it seems like they aren't normal overlays (which do show up in inspects)
) | ||
) | ||
) | ||
(set! v0-21 (the-as none (cond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow this part is awful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed up to cam-start.gc
(again)
) | ||
|
||
|
||
(defbehavior clmf-cam-flag-toggle cam-layout ((arg0 int) (arg1 int)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some messed up bitfield stuff in this function, but probably okay to leave for now
none
cam-layout-save-cam-trans
make an issue!