Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomp: finish _almost all of_ the remaining camera code #845

Merged
merged 40 commits into from
Oct 17, 2021

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Sep 13, 2021

  • cam-master
    • main event handler casts all return values to none
  • pov-camera
  • cam-states
    • finished, need to adjust the res-lump macros
  • cam-states-dbg
  • cam-debug
    • camera-line-dma / camera-line2d not done -- confusing as to what is passed in that is accessed at offset 1792
  • cam-layout
    • a single function - cam-layout-save-cam-trans make an issue!

@xTVaser xTVaser changed the title decomp: finish the remaining camera code decomp: finish _almost all of_ the remaining camera code Sep 22, 2021
@coveralls
Copy link

coveralls commented Sep 22, 2021

Pull Request Test Coverage Report for Build 1350314599

  • 0 of 50 (0.0%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 58.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/ObjectFile/ObjectFileDB_IR2.cpp 0 2 0.0%
decompiler/analysis/static_refs.cpp 0 2 0.0%
decompiler/util/data_decompile.cpp 0 3 0.0%
test/offline/offline_test_main.cpp 0 3 0.0%
decompiler/analysis/find_defstates.cpp 0 15 0.0%
decompiler/IR2/FormExpressionAnalysis.cpp 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
test/offline/offline_test_main.cpp 2 0%
decompiler/analysis/find_defstates.cpp 3 0%
Totals Coverage Status
Change from base Build 1349776122: -0.03%
Covered Lines: 40253
Relevant Lines: 68422

💛 - Coveralls

Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed up to cam-state-dbg.gc

decompiler/config/all-types.gc Outdated Show resolved Hide resolved
decompiler/analysis/find_defstates.cpp Outdated Show resolved Hide resolved
decompiler/config/all-types.gc Outdated Show resolved Hide resolved
@@ -10338,11 +10338,12 @@
;; - Types

(deftype pov-camera (process-drawable)
((flags int32 :offset-assert 176)
((cspace-array cspace-array :offset 112)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting. It really seems like children of process-drawable can customize root to be whatever they want. I wonder if there was a built in language feature for this that we are missing in OpenGOAL. None of these show up in inspect method, so it seems like they aren't normal overlays (which do show up in inspects)

decompiler/config/all-types.gc Show resolved Hide resolved
goal_src/engine/camera/cam-master.gc Outdated Show resolved Hide resolved
)
)
)
(set! v0-21 (the-as none (cond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this part is awful

goal_src/engine/camera/cam-master.gc Outdated Show resolved Hide resolved
goal_src/engine/camera/cam-master.gc Outdated Show resolved Hide resolved
goal_src/engine/camera/cam-master.gc Outdated Show resolved Hide resolved
Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed up to cam-start.gc (again)

goal_src/engine/camera/cam-layout.gc Show resolved Hide resolved
goal_src/engine/camera/cam-layout.gc Outdated Show resolved Hide resolved
goal_src/engine/camera/cam-layout.gc Outdated Show resolved Hide resolved
goal_src/engine/camera/cam-layout.gc Show resolved Hide resolved
)


(defbehavior clmf-cam-flag-toggle cam-layout ((arg0 int) (arg1 int))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some messed up bitfield stuff in this function, but probably okay to leave for now

goal_src/engine/camera/cam-master.gc Outdated Show resolved Hide resolved
@water111 water111 merged commit 45318be into open-goal:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants