Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sparticle] 2d hud particles #849

Merged
merged 22 commits into from
Sep 26, 2021
Merged

[sparticle] 2d hud particles #849

merged 22 commits into from
Sep 26, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Sep 19, 2021

There are still some remaining issues:

  • cannot close the menu. Fixed: leftover (break) from debugging in particle free function
  • depth test is wrong
  • Weird "fade" effect on the sides. Fix: accidentally was using GL_CLAMP instead of GL_CLAMP_TO_EDGE.
  • orange is too orange. Fix: rgba24 -> rgba32 conversion resulted in the wrong alpha, making blending off.
  • powercell rotation is way too fast. Fixed, I ditched their taylor series and used std::sin/std::cos, but forgot to convert from game degrees to radians.
  • pexew is bugged
  • texture cache stuff could use some cleanup
  • missing asm stuff for windows
  • opening volume bars
  • respawning particles while the menu is open seems to not work. For example, activating a powercell with L1/R1 doesn't start the animation. Closing and opening the menu will make it start, but then if you scroll to a page with fewer active powercells and back, the animation won't start. Fix: was caused by the way I disabled some not-yet-implemented things
  • sprites use a lot of draw calls (47 sprites requires 31 draws)

@coveralls
Copy link

coveralls commented Sep 25, 2021

Pull Request Test Coverage Report for Build 1274021541

  • 125 of 3009 (4.15%) changed or added relevant lines in 44 files are covered.
  • 58 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-2.5%) to 60.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
game/runtime.cpp 0 1 0.0%
common/texture/texture_conversion.h 0 2 0.0%
decompiler/data/game_text.cpp 0 2 0.0%
decompiler/util/data_decompile.cpp 3 5 60.0%
game/graphics/dma/dma_chain_read.h 0 2 0.0%
game/graphics/dma/gs.cpp 0 2 0.0%
game/graphics/opengl_renderer/BucketRenderer.h 0 2 0.0%
game/kernel/kmachine.cpp 0 2 0.0%
goalc/listener/MemoryMap.cpp 0 2 0.0%
game/graphics/texture/TextureConverter.cpp 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
decompiler/Function/CfgVtx.cpp 1 64.45%
game/graphics/dma/dma_copy.h 1 0%
game/graphics/opengl_renderer/Shader.cpp 1 0%
game/graphics/texture/TextureConverter.cpp 1 0%
game/graphics/dma/dma_copy.cpp 2 0%
game/graphics/dma/dma.cpp 2 0%
game/graphics/opengl_renderer/OpenGLRenderer.cpp 4 0%
game/graphics/pipelines/opengl.cpp 4 0%
game/graphics/texture/TexturePool.cpp 4 0%
game/mips2c/mips2c_private.h 5 9.86%
Totals Coverage Status
Change from base Build 1260158091: -2.5%
Covered Lines: 40200
Relevant Lines: 66755

💛 - Coveralls

@water111 water111 merged commit f0ceea8 into master Sep 26, 2021
@water111 water111 deleted the w/sparticle-decomp branch September 26, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants