Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pointers set to #f in static structures #864

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Handle pointers set to #f in static structures #864

merged 1 commit into from
Sep 29, 2021

Conversation

water111
Copy link
Collaborator

should fix #861

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1284962895

  • 20 of 29 (68.97%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 60.228%
Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/compilation/Static.cpp 10 11 90.91%
decompiler/util/data_decompile.cpp 6 14 42.86%
Files with Coverage Reduction New Missed Lines %
game/overlord/iso.cpp 1 78.01%
Totals Coverage Status
Change from base Build 1284958479: 0.005%
Covered Lines: 40221
Relevant Lines: 66781
💛 - Coveralls

@water111 water111 merged commit b1e987c into master Sep 29, 2021
@water111 water111 deleted the w/fix-pointer-#f-in-statics branch September 29, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[decomp] allow #f to be used as a static pointer
2 participants
@water111 @coveralls