Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decompiler] clean up offline test program, reorganize decomp order #895

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Oct 12, 2021

Still a work in progress, but offline-test2 is working, at least on linux. If it works on windows, I'm hoping to just get rid of the original. The new version:

  • uses the new order of passes for less RAM usage
  • prints the file name, so you know where it crashes (and prints it just once)
  • colored diffs without the crap in front
  • json config file (config.json in the same file)

Still to-do before merge

  • compile
  • exclude list for states (Vaser has this in a PR already, I just need to make sure the input's easily available for that)
  • verify that the normal decompiler still works
  • fix crash bugs and remove stuff from banned_objects

@xTVaser
Copy link
Member

xTVaser commented Oct 13, 2021

Old system (debug):

  • 7.5minutes before it even starts comparing files!
  • over 18GB of RAM used total!
  • around 13minutes to do the full suite.

New system (debug):

  • way better output
  • still works
  • around 1GB of RAM
  • Starts comparing files immediately
  • total time is within the same ballpark

I imagine if we really cared, since we are doing file-by-file we could likely thread this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants