[debugger] Windows support + process-drawable + joint
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManDude
changed the title
process-drawable
ManDude
changed the title
process-drawableprocess-drawable + joint
|
|
Pull Request Test Coverage Report for Build 1397409601
💛 - Coveralls |
water111
reviewed
Oct 28, 2021
common/cross_os_debug/xdbg.cpp
Outdated
| return false; | ||
| } | ||
|
|
||
| cont_status = 1; |
There was a problem hiding this comment.
you should lock the mutex before setting cont_status, otherwise this can happen:
- lock in
check_stopped check_stoppedcheckscont_status, it is -1- this code sets
cont_status = -1 - this code does a
notify_all check_stoppeddoes a wait, then gets stuck there.
| /*! | ||
| * Cross-thread things. | ||
| */ | ||
| int cont_status = -1; // hack? -1 = ignore; 0 = waiting for cont; 1 = cont'd, will resume |
There was a problem hiding this comment.
does something reset this to -1 if you restart the runtime in the middle of debugging? (maybe it doesn't matter)
| @@ -233,6 +233,37 @@ gc> (:disasm (sym-val basic-type?) 80) | |||
|
|
|||
| For now, the disassembly is pretty basic, but it should eventually support GOAL symbols. | |||
|
|
|||
| ### `(:sym-name)` | |||
|
|
|||
| Print the name of a symbol from its offset. The name is fetched from memory. | |||
There was a problem hiding this comment.
nice, this will be a useful feature
goalc/debugger/Debugger.cpp
Outdated
| @@ -14,6 +15,10 @@ | |||
| #include "goalc/listener/Listener.h" | |||
| #include "third-party/fmt/core.h" | |||
|
|
|||
| namespace { | |||
| std::mutex watcher_mutex; | |||
There was a problem hiding this comment.
Can we move this to m_watcher_mutex in Debugger?
There was a problem hiding this comment.
Apparently there's already a m_watcher_mutex field so I just re-used that. Should be okay?
goalc/debugger/Debugger.cpp
Outdated
| @@ -572,6 +609,7 @@ void Debugger::start_watcher() { | |||
| assert(!m_watcher_running); | |||
| m_watcher_running = true; | |||
| m_watcher_should_stop = false; | |||
| m_attach_return = false; | |||
There was a problem hiding this comment.
should lock the mutex before changing this
|
Looks like these two files havn't been added to the reference tests |
water111
approved these changes
Oct 29, 2021
|
merged in #953 |
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.