Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve debugger disasm, :sym-name and fix Windows builds #959

Merged
merged 9 commits into from
Nov 13, 2021
Merged

improve debugger disasm, :sym-name and fix Windows builds #959

merged 9 commits into from
Nov 13, 2021

Conversation

ManDude
Copy link
Member

@ManDude ManDude commented Nov 11, 2021

No description provided.

@coveralls
Copy link

coveralls commented Nov 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1454349579

  • 9 of 57 (15.79%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.654%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/util/FileUtil.cpp 0 2 0.0%
goalc/compiler/compilation/Debug.cpp 0 5 0.0%
goalc/debugger/Debugger.cpp 9 50 18.0%
Files with Coverage Reduction New Missed Lines %
goalc/debugger/Debugger.cpp 1 72.73%
common/util/FileUtil.cpp 2 26.11%
Totals Coverage Status
Change from base Build 1442623097: -0.03%
Covered Lines: 40358
Relevant Lines: 70000
💛 - Coveralls

@ManDude
Copy link
Member Author

ManDude commented Nov 11, 2021

Codacy is not aware that uintptr_t on Windows is unsigned long long and thus llx would be appropriate...

xTVaser
xTVaser reviewed Nov 12, 2021
View reviewed changes
CMakePresets.json Outdated
"binaryDir": "${sourceDir}/out/build/${presetName}",
"binaryDir": "${sourceDir}/out/build/Debug",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to just change the "name" above to Debug or Release below instead of hard-coding it. I've made this change in a few of my PRs as well.

@water111 water111 merged commit ff50cf2 into open-goal:master Nov 13, 2021
@ManDude ManDude deleted the d/debugger-improves branch November 13, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xTVaser xTVaser xTVaser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ManDude @coveralls @xTVaser @water111