Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amalgamate FileIO and remove duplicate Timer header #96

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Amalgamate FileIO and remove duplicate Timer header #96

merged 1 commit into from
Oct 25, 2020

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Oct 25, 2020

Cleaning up this longstanding issue since it's a quick one.

Closes #8

@coveralls
Copy link

Pull Request Test Coverage Report for Build 326957725

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 81.916%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/util/FileUtil.cpp 0 26 0.0%
Totals Coverage Status
Change from base Build 326760679: -0.1%
Covered Lines: 15120
Relevant Lines: 18458
💛 - Coveralls

water111
water111 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@water111 water111 merged commit 5985eaa into open-goal:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@water111 water111 water111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move file I/O utilities to a single library
3 participants
@xTVaser @coveralls @water111